Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate references #4368

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Dec 16, 2020

The DotNetNuke.Library project (i.e. DotNetNuke.dll) has many duplicate references, one to a project (e.g. DotNetNuke.Instrumentation) and another to the output of that project (e.g. ..\DotNetNuke.Instrumentation\bin\DotNetNuke.Instrumentation.dll)

This removes all of the assembly references when a project reference exists. It also replaces the assembly reference for DotNetNuke.Syndication with a project reference.

Prefer project references to assembly references
@valadas valadas added this to the 9.8.1 milestone Dec 16, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this might explain some issue I had too...

@valadas valadas modified the milestone: 9.8.1 Dec 16, 2020
@valadas valadas merged commit 1b8d36c into dnnsoftware:develop Dec 16, 2020
@bdukes bdukes deleted the remove-duplicate-references branch December 22, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants